Commits

Markus Andreassen authored d4305e24718
126.16 Review rettelser
No tags

ecpr2-service/src/main/java/dk/sds/ecpr2/util/SlaLogger.java

Modified
40 40 public SlaLogger(String name) {
41 41 this.name = name;
42 42 synchronized (lock) {
43 43 if (slaLogInstance == null) {
44 44 slaLogInstance = new SLALogConfig(SHORT_APP_NAME, SHORT_APP_NAME);
45 45 }
46 46 }
47 47 }
48 48
49 49 public void addSlaLog(SLALogItem slaLogItem, long startNanos, long startMillis, String errorMessage) {
50 - if (slaLogInstance != null && slaLogItem != null) {
51 - try {
52 - SLALogItem logItem = slaLogInstance.getSLALogger().createLogItem(SHORT_APP_NAME + "." + name, SHORT_APP_NAME + "." + name);
53 -
54 - logItem.setClientIP(slaLogItem.getClientIP());
55 - logItem.setSourceSOAPAction(slaLogItem.getSourceSOAPAction());
56 - logItem.setSourceOperation(slaLogItem.getSourceOperation());
57 - logItem.setSourceEndpoint(slaLogItem.getSourceEndpoint());
58 - logItem.setMessageId(slaLogItem.getMessageId());
59 - logItem.setStartTime(startNanos, startMillis);
60 - logItem.setEndTime(System.nanoTime(), System.currentTimeMillis());
50 + if (slaLogInstance == null) {
51 + log.error("No slaLogInstance has been created");
52 + return;
53 + }
54 + if (slaLogItem == null) {
55 + log.error("No slaLogItem was supplied");
56 + return;
57 + }
58 + try {
59 + SLALogItem logItem = slaLogInstance.getSLALogger().createLogItem(SHORT_APP_NAME + "." + name, SHORT_APP_NAME + "." + name);
61 60
62 - if (errorMessage == null) {
63 - logItem.setCallResultOk();
64 - } else {
65 - logItem.setCallResultError(errorMessage);
66 - }
61 + logItem.setClientIP(slaLogItem.getClientIP());
62 + logItem.setSourceSOAPAction(slaLogItem.getSourceSOAPAction());
63 + logItem.setSourceOperation(slaLogItem.getSourceOperation());
64 + logItem.setSourceEndpoint(slaLogItem.getSourceEndpoint());
65 + logItem.setMessageId(slaLogItem.getMessageId());
66 + logItem.setStartTime(startNanos, startMillis);
67 + logItem.setEndTime(System.nanoTime(), System.currentTimeMillis());
67 68
68 - logItem.store();
69 - } catch (Exception ex) {
70 - log.error("Could not create SLA LogItem", ex);
71 - }
72 - } else {
73 - if (slaLogInstance == null) {
74 - log.error("No slaLogInstance has been created");
69 + if (errorMessage == null) {
70 + logItem.setCallResultOk();
75 71 } else {
76 - log.error("No slaLogItem was supplied");
72 + logItem.setCallResultError(errorMessage);
77 73 }
74 +
75 + logItem.store();
76 + } catch (Exception ex) {
77 + log.error("Could not create SLA LogItem", ex);
78 78 }
79 79 }
80 80 }
81 81

Everything looks good. We'll let you know here if there's anything you should know about.

Add shortcut